Re: [coreboot] [PATCH] fix object/driver confusion ofall northbridge code

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Peter Stuge
> Sent: Tuesday, March 24, 2009 10:06 AM
> To: [e-mail]
> Subject: Re: [coreboot] [PATCH] fix object/driver confusion ofall
> northbridge code
>
> Stefan Reinauer wrote:
> > Every object file with a struct pci_driver ... __pci_driver needs to
> > be marked as "driver" instead of "object" in order to get the init
> > code actually executed.
> >
> > This patch fixes up all northbridges that did not do this before.
> >
> > Signed-off-by: Stefan Reinauer
>
> Acked-by: Peter Stuge
>
> How come we have not noticed this before? Do these NB drivers not do
> anything critical?

It is hard to believe that the amdk8 northbridge code never got executed.
Is this only true if it's not contained in a "chip", or if you don't specify
its position in the device tree?

Thanks,
Myles