Re: [coreboot] [PATCH] add high tables support for supermicro h8dme

[Peter Stuge]

Ward Vandewege wrote:
> +++ src/mainboard/supermicro/h8dme/mainboard.c	(working copy)
> @@ -16,13 +16,23 @@
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */
>
> +#include <device/device.h>
>  #include <console/console.h>
> -#include <device/device.h>
> -#include <device/pci.h>
> -#include <device/pci_ids.h>
> -#include <device/pci_ops.h>
> +#include <boot/tables.h>
>  #include "chip.h"
>
> +/* in arch/i386/boot/tables.c */
> +extern uint64_t high_tables_base, high_tables_size;
>
> +int add_mainboard_resources(struct lb_memory *mem)
> +{
> +#if HAVE_HIGH_TABLES == 1
> lb_add_memory_range(mem, LB_MEM_TABLE,
> high_tables_base, high_tables_size);
>
> +#endif
> return 0;
>
> +}

Case in point: Isn't this very similar to the vt8454 code?

//Peter