Re: [coreboot] [PATCH] superiotool: dump winbond hardware monitor registers

[Stefan Reinauer]

Uwe Hermann wrote:
> On Sat, Nov 29, 2008 at 12:04:17AM +0100, Stefan Reinauer wrote:
> > Not all LDNs are switched via register offset 0x07, make it a parameter
> > add support for dumping the hardware monitor of Winbond W83627THF/THG 
> > parts with -e
> >
> > Signed-off-by: Stefan Reinauer
>
> Nice, thanks! Acked, and committed in r3784 with a few minor changes:

cool thanks.
> Can you post a sample dump of this Super I/O with '-e'? The 0x4f
> register here is a bit unclear, the datasheet (page 48) says that it's
> 16 bit. Seems like the default is 0x5c or 0xa3, depending on 0x4e bit 7?
> Maybe we should make the value of 0x4e 'MISC' instead, as 0x5c is not
> always correct.

The value of 0x4f depends on the upper bit of the bank select register.

Stefan