[coreboot] Patch set updated for coreboot: 0f06a79 AMD northbridges: drop dead code

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1187

-gerrit

commit 0f06a796f9c76c6b967b0e9798264ae1464e33f2
Author: Kyösti Mälkki 
Date:   Mon Jul 9 15:49:12 2012 +0300

AMD northbridges: drop dead code

Change-Id: I03949722ac3a127319a0ad3f812d77ba7b8f139f
    Signed-off-by: Kyösti Mälkki 
---
 src/cpu/amd/dualcore/amd_sibling.c |   83 ------------------------------------
 1 files changed, 0 insertions(+), 83 deletions(-)

diff --git a/src/cpu/amd/dualcore/amd_sibling.c b/src/cpu/amd/dualcore/amd_sibling.c
index ea5114c..3870222 100644
--- a/src/cpu/amd/dualcore/amd_sibling.c
+++ b/src/cpu/amd/dualcore/amd_sibling.c
@@ -116,87 +116,4 @@ unsigned get_apicid_base(unsigned ioapic_num)
    return apicid_base;
 }

-#if 0
-static int first_time = 1;
-
-void amd_sibling_init(device_t cpu)
-{
-	unsigned i, siblings;
-	struct cpuid_result result;
-	unsigned nb_cfg_54;
-	struct node_core_id id;
-
-	/* On the bootstrap processor see if I want sibling cpus enabled */
-	if (first_time) {
-		first_time = 0;
-		get_option(&disable_siblings, "multi_core");
-	}
-	result = cpuid(0x80000008);
-	/* See how many sibling cpus we have */
-	/* Is dualcore supported */
-	siblings = (result.ecx & 0xff);
-	if ( siblings < 1) {
-		return;
-	}
-
-#if 1
-	printk(BIOS_DEBUG, "CPU: %u %d siblings\n",
-		cpu->path.apic.apic_id,
-		siblings);
-#endif
-
-	nb_cfg_54 = read_nb_cfg_54();
-#if 1
-	id = get_node_core_id(nb_cfg_54); // pre e0 nb_cfg_54 can not be set
-
-	/* See if I am a sibling cpu */
-	//if ((cpu->path.apic.apic_id>>(nb_cfg_54?0:3)) & siblings ) { // siblings = 1, 3, 7, 15,....
-	//if ( ( (cpu->path.apic.apic_id>>(nb_cfg_54?0:3)) % (siblings+1) ) != 0 ) {
-	if(id.coreid != 0) {
-	        if (disable_siblings) {
-                        cpu->enabled = 0;
-                }
-                return;
-	}
-#endif
-
-	/* I am the primary cpu start up my siblings */
-
-	for(i = 1; i <= siblings; i++) {
-		struct device_path cpu_path;
-		device_t new;
-		/* Build the cpu device path */
-		cpu_path.type = DEVICE_PATH_APIC;
-		cpu_path.apic.apic_id = cpu->path.apic.apic_id + i * (nb_cfg_54?1:8);
-                if(id.nodeid == 0) {
-                        // need some special processing, because may the bsp is not lifted, but the core1 is lifted
-			//defined in northbridge.c
-                        if(sysconf.enabled_apic_ext_id && (!sysconf.lift_bsp_apicid)) {
-                        	cpu->path.apic.apic_id += sysconf.apicid_offset;
-                        }
-
-                }
-
-
-                /* See if I can find the cpu */
-                new = find_dev_path(cpu->bus, &cpu_path);
-		/* Allocate the new cpu device structure */
-		if(!new) {
-			new = alloc_dev(cpu->bus, &cpu_path);
-			new->enabled = 1;
-			new->initialized = 0;
-		}
-
-
-#if 1
-		printk(BIOS_DEBUG, "CPU: %u has sibling %u\n",
-			cpu->path.apic.apic_id,
-			new->path.apic.apic_id);
-#endif
-
-		if(new->enabled && !new->initialized)
-			start_cpu(new);
-	}
-}
-#endif