Re: [coreboot] [PATCH]es: abuild, acpigen, scan-build results

[Patrick Georgi]

Am 21.04.2009 18:18, schrieb Carl-Daniel Hailfinger:
> On 21.04.2009 17:57, Patrick Georgi wrote:
> > Copyright (C) 2005-2007 Stefan Reinauer
> > Copyright (C) 2005-2009 coresystems GmbH
>
> That's a bit unusual. I'd have expected the author name to remain:
> Copyright (C) 2005-2009 coresystems GmbH
> Written by Stefan Reinauer for coresystems GmbH

I'll add that.
> > @@ -927,7 +925,7 @@
> >    	if (	(id == 0xffffffff) || (id == 0x00000000) ||
> >    		(id == 0x0000ffff) || (id == 0xffff0000))
> >    	{
> > 	printk_spew("%s, bad id 0x%x\n", dev_path(&dummy), id);
> > 	// printk_spew("PCI: devfn 0x%x, bad id 0x%x\n", devfn, id);
>
> That change seems unrelated. Please revert.

will do
> > @@ -93,9 +93,8 @@
> >
> > void add_console(struct lb_header *header, u16 consoletype)
> >   {
> > struct lb_record *rec;
> > struct lb_console *console;
> > rec = lb_new_record(header);
>
> I believe this is incorrect. The removed call modified *header and that
> change is now missing.

That header is an empty one, see the line below.
> > console = (struct lb_console *)lb_new_record(header);
> >  console->tag = LB_TAG_CONSOLE;
> >  console->size = sizeof(*console);

Patrick