Re: [coreboot] [PATCH] Get rid of unaligned 32-bit config space read in mcd_d.c

[Marc Jones]

On Mon, Apr 12, 2010 at 12:52 AM, Arne Georg Gleditsch
 wrote:
> Hi,
>
> This patch removes a non-32-bit aligned Get_NB32 from
> src/northbridge/amd/amdmct/mct/mct_d.c.  The actual behavior should be
> unchanged for I/O-based config space reads, but previous behavior was
> wrong for MMCFG-based config space reads.
>
> Perhaps we want pci_mmio_*_config* to enforce natural alignment as well?
>
> Signed-off-by: Arne Georg Gleditsch

Hi Arne,

That code is doing something a little ugly to make the two cs
registers use the one mask register. It was ported from a routine that
assumed that GET_NB32() fixed the alignment. Maybe add a comment about
why that is happening.

Acked-by: Marc Jones

I would also ack a change to:
u32 Get_NB32(u32 dev, u32 reg)
u32 Get_NB32(u32 dev, u32 reg)

or to the  pci_mmio_*_config* to do it since the pci_io* versions do.

Marc