Re: [coreboot] [coreboot-gerrit] New patch to review for coreboot: 7d39656 lenovo/x60/romstage.c: Collect timestamps in romstage

[Peter Stuge]

ron minnich wrote:
> > commit 7d396566be210dfd5f86c8d9038ae0fdacefa02f
> > Author: Paul Menzel 
> > Date:   Tue Jul 2 09:54:17 2013 +0200
> > lenovo/x60/romstage.c: Collect timestamps in romstage
> >
> > Collect early timestamps in Lenovo X60’s romstage.
>
> This is fine.

Not really, those two lines are completely redundant.
> > Thanks to Nico Huber’s work setting this up for the ICH7 and implementing
> > it for the T60, all what was needed to do, was to do the equivalent
> > changes for the X60 as for the T60 in commit 44c392f8 [1].
> >
> >     lenovo/t60: Collect timestamps in romstage
> >
> > [1] http://review.coreboot.org/3499
>
> remove all this text. It's not needed.

The text is not needed, the link to gerrit is redundant, but the
commit reference is nice to have. The commit message probably
fits in about three lines.

//Peter