Re: [coreboot] [PATCH] Maximum/default console log level for kconfig

[Peter Stuge]

Uwe Hermann wrote:
> Make console maximum/default log level a choice option.
>
> Signed-off-by: Uwe Hermann
> Index: src/console/Kconfig
>
> --- src/console/Kconfig	(Revision 4756)
> +++ src/console/Kconfig	(Arbeitskopie)
> @@ -78,18 +78,119 @@
>    help
>      If not selected, the last adapter found will be used.
>
> -# TODO: User-friendly "choice" selection.
> -# TODO: Add help text.
> +choice
>    prompt "Maximum console log level"
>    default MAXIMUM_CONSOLE_LOGLEVEL_8

What does this mean? Maybe a help text?
> +config MAXIMUM_CONSOLE_LOGLEVEL_8
>    bool "8: BIOS_SPEW"

Please remove BIOS_ from all these strings. coreboot isn't a BIOS.
Then it's

Acked-by: Peter Stuge