Re: [coreboot] [PATCH][v2] buildtarget tries to apply make syntax to shell

[Peter Stuge]

Jordan, was this the only problem with buildtarget?

On Fri, Jan 25, 2008 at 07:16:57PM +0100, Patrick Georgi wrote:
> bsh/ksh-clone and make(1)-syntax don't go well together
> (unlike 5 lines later where make syntax is emitted into a file)
>
> Signed-off-by: Patrick Georgi

Acked-by: Peter Stuge
> Index: targets/buildtarget
>
> --- targets/buildtarget	(Revision 3075)
> +++ targets/buildtarget	(Arbeitskopie)
> @@ -72,7 +72,7 @@
>  ld --help | awk '{for (i=1;i<=NF;i++) if ($i ~ /build-id/){n++} }; END {exit n}' 
>  build_id=$?
>  if [ $build_id -ge 1 ] ; then
> EXTRA_LFLAGS+=" -Wl,--build-id=none"
> EXTRA_LFLAGS="$EXTRA_LFLAGS -Wl,--build-id=none"
>
> fi
>
> for i in $build_dir/Makefile.settings $build_dir/*/Makefile.settings