I refactored the patches to simplify reviewing. In a coming patch there are some bugfixes in amdk8_util.asl, so this will help with maintenance.
changes by file: src/arch/i386/boot/acpi.c: Be Paranoid and set srat_lapic table to zero before filling it. Enable SLIT filling if acpi_create_slit gets called.
src/northbridge/amd/amdk8/amdk8_util.asl: Put this file here instead of every board having a personal copy.
src/northbridge/amd/amdfam10/amdfam10_util.asl: Put this file here instead of every board having a personal copy.
src/mainboard/.../dsdt.dsl: Change the path to amd*_util.asl
src/arch/i386/include/arch/acpi.h: Add slit prototype and minor whitespace.
This patch is abuild tested.
Signed-off-by: Myles Watson mylesgw@gmail.com
I didn't see the deletion of the per-board copies. Did subversion forget to include them in the diff?
I will follow the patch with
svn rm src/mainboard/iwill/dk8_htx/dx/amdk8_util.asl svn rm src/mainboard/amd/serengeti_cheetah/dx/amdk8_util.asl svn rm src/mainboard/amd/serengeti_cheetah_fam10/dx/amdfam10_util.asl svn rm src/mainboard/asus/m2v-mx_se/amdk8_util.asl
Besides that, moving the related fam10 file as well would be nice.
Done.
Maybe also a splitout of the K8 util ACPI code from the DBM690T and Pistachio code, but that seems to be more work.
The ACPI code is totally different for those boards. It doesn't even use the same functions. The util files for those boards could be moved somewhere central, but I think it's best left for another patch.
Thanks, Myles