attached patch moves the mptable entries for ISA bus interrupts (ie. the legacy stuff) to generic code. Instead of the hogde-podge in each board's mptable.c, it's relatively clean code in arch/i386 now.
Thanks for doing this.
As this is quite a large patch, affecting lots of boards, I'd welcome some review that I didn't delete a line too much or something like that.
Index: src/mainboard/amd/mahogany_fam10/mptable.c
--- src/mainboard/amd/mahogany_fam10/mptable.c (revision 5574) +++ src/mainboard/amd/mahogany_fam10/mptable.c (working copy) @@ -122,24 +122,8 @@ #define IO_LOCAL_INT(type, intr, apicid, pin) \ smp_write_intsrc(mc, (type), MP_IRQ_TRIGGER_EDGE |
MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin));
- IO_LOCAL_INT(mp_ExtINT, 0x0, apicid_sb700, 0x0);
- mptable_add_isa_interrupts(mc, bus_isa, apicid_sb700, 0);
It looks like IO_LOCAL_INT should be removed, since it uses bus_isa. Same for tilapia & probably other similar mainboards.
/*I/O Ints: Type Polarity Trigger
Bus ID IRQ APIC ID PIN# */
smp_write_intsrc(mc, mp_INT,
MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[0], ((sbdn+1)<<2)|1, m->apicid_mcp55, 0xa);
In some places you reformat the comment, in others you just remove it.
It's abuild tested and Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Acked-by: Myles Watson mylesgw@gmail.com
Thanks, Myles