Re: [LinuxBIOS] GIGABYTE GA-2761GXDK

[Uwe Hermann]

[Shortening the CC list a bit]

On Tue, Oct 30, 2007 at 11:17:57AM -0600, Jordan Crouse wrote:
> [BUILDROM]  Add support for the GIGABYTE GA-2761GXDK
>
> Add buildrom support for the new GIGABYTE board added to LinuxBIOS.
>
> Signed-off-by: Jordan Crouse
> Index: buildrom-devel/config/payloads/Config.in
>
> --- buildrom-devel.orig/config/payloads/Config.in	2007-10-31 12:24:26.000000000 -0600
> +++ buildrom-devel/config/payloads/Config.in	2007-10-31 12:27:36.000000000 -0600
> @@ -24,10 +24,12 @@
>    select PAYLOAD
>
> config PAYLOAD_KERNEL
> depends !PLATFORM_GA_2761GXDK
> bool "Linux kernel payload"
> select PAYLOAD
>
> config PAYLOAD_LAB
> depends !PLATFORM_GA_2761GXDK
> bool "Linux As Bootloader"
> select PAYLOAD
> Index: buildrom-devel/config/platforms/Config.in
>
> --- buildrom-devel.orig/config/platforms/Config.in	2007-10-31 12:24:26.000000000 -0600
> +++ buildrom-devel/config/platforms/Config.in	2007-10-31 12:26:02.000000000 -0600
> @@ -61,6 +61,11 @@
>         depends VENDOR_GIGABYTE
>         select PLATFORM
>
> +config PLATFORM_GA_2761GXDK
> bool "GIGABYTE GA-2761GXDK"
> depends VENDOR_GIGABYTE
> select PLATFORM
>
> config PLATFORM_TYAN_S2882
>         bool "Tyan S2882"
>         depends VENDOR_TYAN
> Index: buildrom-devel/config/platforms/platforms.conf
> ===================================================================
> --- buildrom-devel.orig/config/platforms/platforms.conf	2007-10-31 12:24:26.000000000 -0600
> +++ buildrom-devel/config/platforms/platforms.conf	2007-10-31 12:26:11.000000000 -0600
> @@ -15,5 +15,6 @@
>  PLATFORM-$(CONFIG_PLATFORM_TYAN_S2882) = tyan-s2882.conf
>  PLATFORM-$(CONFIG_PLATFORM_TYAN_S2891) = tyan-s2891.conf
>  PLATFORM-$(CONFIG_PLATFORM_SERENGETI_CHEETAH) = serengeti_cheetah.conf
> +PLATFORM-$(CONFIG_PLATFORM_GA_2761GXDK) = ga-2761gxdk.conf
>
> include $(CONFIG_DIR)/platforms/$(PLATFORM-y)
> Index: buildrom-devel/config/platforms/ga-2761gxdk.conf
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/config/platforms/ga-2761gxdk.conf	2007-10-31 12:25:13.000000000 -0600
> @@ -0,0 +1,40 @@
> +# Support for the Gigabyte GA-2761GXDK board with the SIS761 chipset

"SiS761GX/966L" chipset?
> +#### Platform configuration
>
> +CC=gcc
> +STRIP=strip
> +AS=as
>
> +TARGET_ARCH=i686
> +CFLAGS_platform = -m32
>
> +# Targets
>
> +# Disable for now - I don't know the right kernel for this platform
> +#KERNEL_MK=$(PACKAGE_DIR)/kernel/m57sli-kernel.mk

Can be dropped or adapted to this board? m57sli is wrong.
> +LINUXBIOS_MK=$(PACKAGE_DIR)/linuxbios/ga-2761gxdk-linuxbios.mk
>
> +# kernel configuration (for LAB)
>
> +# Disable for now - I don't know the right kernel for this platform
> +#KERNEL_VERSION=2.6.22.2
> +#KERNEL_CONFIG=$(PACKAGE_DIR)/kernel/conf/m57sli-defconfig

Ditto.
> +UCLIBC_ARCH=i386
>
> +# Etherboot configuration
> +ETHERBOOT_ARCH=i386
>
> +# LinuxBIOS configuration
>
> +LINUXBIOS_VENDOR=gigabyte
> +LINUXBIOS_BOARD=ga_2761gxdk
> +LINUXBIOS_CONFIG=Config.lb
> +LINUXBIOS_TDIR=ga_2761gxdk
> +LINUXBIOS_TAG=2908
> +LINUXBIOS_ROM_NAME=linuxbios.rom
>
> +# FILO configuration
>
> +FILO_CONFIG=ga-2761gxdk-Config
> Index: buildrom-devel/packages/filo/conf/ga-2761gxdk-Config
>
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/filo/conf/ga-2761gxdk-Config	2007-10-31 12:25:13.000000000 -0600
> @@ -0,0 +1,50 @@
> +# Use grub instead of autoboot?
> +USE_GRUB = 1
> +# Grub menu.lst path
> +MENULST_FILE = "hde1:/boot/grub/menu.lst"
> +# Driver for hard disk, CompactFlash, and CD-ROM on IDE bus
> +IDE_DISK = 1
> +# Add a short delay when polling status registers
> +# (required on some broken SATA controllers)
> +IDE_DISK_POLL_DELAY = 1
> +# Driver for USB Storage
> +USB_DISK = 1
> +# VGA text console
> +VGA_CONSOLE = 1
> +PC_KEYBOARD = 1
> +# Enable the serial console
> +SERIAL_CONSOLE = 1
> +# Serial console; real external serial port
> +SERIAL_IOBASE = 0x3f8
> +SERIAL_SPEED = 115200
> +# Filesystems
> +FSYS_EXT2FS = 1
> +FSYS_ISO9660 = 1
> +# Support for boot disk image in bootable CD-ROM (El Torito)
> +ELTORITO = 1
> +# PCI support
> +SUPPORT_PCI = 1
> +# Enable this to scan PCI busses above bus 0
> +# AMD64 based boards do need this.
> +PCI_BRUTE_SCAN = 1
> +# Loader for standard Linux kernel image, a.k.a. /vmlinuz
> +LINUX_LOADER = 1
>
> +# Debugging
> +#DEBUG_ALL = 1
> +#DEBUG_ELFBOOT = 1
> +#DEBUG_ELFNOTE = 1
> +#DEBUG_LINUXBIOS = 1
> +#DEBUG_MALLOC = 1
> +#DEBUG_MULTIBOOT = 1
> +#DEBUG_SEGMENT = 1
> +#DEBUG_SYS_INFO = 1
> +#DEBUG_TIMER = 1
> +#DEBUG_BLOCKDEV = 1
> +#DEBUG_PCI = 1
> +#DEBUG_VIA_SOUND = 1
> +#DEBUG_LINUXLOAD = 1
> +#DEBUG_IDE = 1
> +#DEBUG_USB = 1
> +#DEBUG_ELTORITO = 1
> Index: buildrom-devel/packages/linuxbios/ga-2761gxdk-linuxbios.mk
>
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/linuxbios/ga-2761gxdk-linuxbios.mk	2007-10-31 12:25:13.000000000 -0600
> @@ -0,0 +1,31 @@
> +# This is the Generic LinuxBIOS target
>
> +ifeq ($(CONFIG_PLATFORM),y)
> +ifeq ($(LINUXBIOS_TAG),)
> +$(error You need to specify a version to pull in your platform config)
> +endif
> +endif
>
> +LINUXBIOS_PATCHES=$(PACKAGE_DIR)/linuxbios/patches/2761gxdk-fix-target.patch
>
> +LINUXBIOS_BASE_DIR=svn
> +LINUXBIOS_URL=svn://linuxbios.org/repos/trunk/LinuxBIOSv2
> +LINUXBIOS_TARBALL=linuxbios-svn-$(LINUXBIOS_TAG).tar.gz
> +LINUXBIOS_PAYLOAD_TARGET=$(LINUXBIOS_BUILD_DIR)/payload.elf
> +TARGET_ROM = $(LINUXBIOS_VENDOR)-$(LINUXBIOS_BOARD).rom
>
> +include $(PACKAGE_DIR)/linuxbios/linuxbios.inc
>
> +$(SOURCE_DIR)/$(LINUXBIOS_TARBALL):
> @ echo "Fetching the LinuxBIOS code..."
> @ mkdir -p $(SOURCE_DIR)/linuxbios
> @ $(BIN_DIR)/fetchsvn.sh $(LINUXBIOS_URL) $(SOURCE_DIR)/linuxbios \
> $(LINUXBIOS_TAG) $(SOURCE_DIR)/$(LINUXBIOS_TARBALL) \
> > $(LINUXBIOS_FETCH_LOG) 2>&1
>
> +$(OUTPUT_DIR)/$(TARGET_ROM): $(LINUXBIOS_OUTPUT)
> @ cat $(LINUXBIOS_OUTPUT) > $@
>
> +linuxbios: $(OUTPUT_DIR)/$(TARGET_ROM)
> +linuxbios-clean: generic-linuxbios-clean
> +linuxbios-distclean: generic-linuxbios-distclean
> Index: buildrom-devel/packages/linuxbios/patches/2761gxdk-fix-target.patch
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/linuxbios/patches/2761gxdk-fix-target.patch	2007-10-31 12:25:13.000000000 -0600

What's this? Empty file? Am I missing something?
> @@ -0,0 +1,24 @@
> +Index: svn/targets/gigabyte/ga_2761gxdk/Config.lb
> +===================================================================
> +--- svn.orig/targets/gigabyte/ga_2761gxdk/Config.lb
> ++++ svn/targets/gigabyte/ga_2761gxdk/Config.lb
> +@@ -42,7 +42,8 @@ romimage "normal"
> #	option ROM_IMAGE_SIZE=0x15800
> option XIP_ROM_SIZE=0x40000
> option LINUXBIOS_EXTRA_VERSION="$(shell cat ../../VERSION)_Normal"
>
> +-        payload ../../../../payloads/filo_uda1.elf
> ++#        payload ../../../../payloads/filo_uda1.elf
> ++	payload ../payload.elf

Yep, but also drop the commented lines, not needed.
> end
> romimage "fallback"
>
> +@@ -55,7 +56,8 @@ romimage "fallback"
> #	option ROM_IMAGE_SIZE=0x15800
> option XIP_ROM_SIZE=0x40000
> option LINUXBIOS_EXTRA_VERSION="$(shell cat ../../VERSION)_Fallback"
>
> +-        payload ../../../../payloads/filo_uda1.elf
> ++#        payload ../../../../payloads/filo_uda1.elf
> ++	payload ../payload.elf
> end
> romimage "failover"

With the above fixes:
Acked-by: Uwe Hermann

Uwe.