Re: [coreboot] [PATCH] flashrom: Add bus type annotation+support

[Uwe Hermann]

On Sun, May 31, 2009 at 01:33:56AM +0200, Carl-Daniel Hailfinger wrote:
> Add bus type annotation to struct flashchips. Right now, the annotation
> only differentiates between SPI and non-SPI. Anyone who knows more about
> a specific flash chip should feel free to update it.
>
> The existing flashbus variable was abused to denote the SPI controller
> type. Use an aptly named variable for that purpose.
>
> Once this patch is merged, the chipset/programmer init functions can set
> supported flash chip types and flashrom can automatically select only
> matching probe/read/erase/write functions.
> A side benefit of that will be the elimination of the Winbond W29EE011
> vs. AMIC A49LF040A conflict.

And also, we can now add support for printing the chip bus type(s) in
'flashrom -L' output and in wiki output (new patch pending, will send).
> Signed-off-by: Carl-Daniel Hailfinger

Looks good and builds fine for me.

Acked-by: Uwe Hermann

Uwe.