Re: [coreboot] [PATCH] v3: Fix ADL MSM800SEV build

[Carl-Daniel Hailfinger]

On 11.07.2008 15:56, Uwe Hermann wrote:
> See patch.
>
> Someone with the board should check if '15,2' is really correct, and
> whether it makes sense to enable IDE or not for this board.
>
> Thanks, Uwe.
> Fix a build-error because of a missing 'enable_ide'.

In theory, this should not cause a build error. Then again, our DTS
concept still needs some tweaks.
> Signed-off-by: Uwe Hermann
> Index: mainboard/adl/msm800sev/dts
>
> --- mainboard/adl/msm800sev/dts	(Revision 694)
> +++ mainboard/adl/msm800sev/dts	(Arbeitskopie)
> @@ -37,6 +37,10 @@
>    	pci@1,1 {
>    		/config/("southbridge/amd/cs5536/dts");
>    	};
> pci@15,2 {
> 	/config/("southbridge/amd/cs5536/ide");
> 	enable_ide = "1";

What about removing the line above? In theory, stuff should still compile.
> };
> ioport@46 {
> 	/config/("superio/winbond/w83627hf/dts");
> 	com1enable = "1";

Regards,
Carl-Daniel