On Thu, Jul 24, 2008 at 9:16 AM, Stefan Reinauer stepan@coresystems.de wrote:
ron minnich wrote:
So I started to fix it up with names and respond to the other comments.
Turns out you can't do this: #include <pci/pci.h>
#include <device/pci_ids.h>
Why would you pull in both libpci and coreboot headers?
so I can say AMD instead of 0x1022. the standard PCI includes don't have that.
libpci pretty much brings its own PCI ID database.
well, sort of. What did I miss?
We have a collection of such utilities, and they're quite nice... mptable, pirq, inteltool, superiotool, there is even one for sc520 iirc.
Things are improving over time. Think of how flash_and_burn starting as a shellscript calling setpci and it evolved into flashrom eventually.
I think it's awesome that you write another one of these tools... They're an important step towards automation of coreboot ports
I'll try again tonight.
thanks again.
ron