Author: hailfinger Date: 2009-04-22 15:33:43 +0200 (Wed, 22 Apr 2009) New Revision: 4177
Modified: trunk/util/flashrom/flashchips.c Log: All "unknown xy SPI chip" entries claim to have status UNTESTED for probe/read/erase/write. That is incorrect.
A bit of confusion comes from how the #defines are named. We call them TEST_BAD_*, but the message printed by flashrom says: "This flash part has status NOT WORKING for operations:"
Something that is unimplemented is definitely not working.
Neither of the chip entries mentioned above has erase or write functions implemented, so erase and write are not working. Since their size is unknown, we can't read them in. That means read is not working as well. Probing is a different matter. If a chip-specific probe function had matched, we wouldn't have to handle the chip with the "unknown xy SPI chip" fallback. I'm tempted to call that "not working" as well, but I'm open to discussion on this point.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-04-22 12:38:23 UTC (rev 4176) +++ trunk/util/flashrom/flashchips.c 2009-04-22 13:33:43 UTC (rev 4177) @@ -2167,7 +2167,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2180,7 +2180,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2193,7 +2193,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2206,7 +2206,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2219,7 +2219,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2232,7 +2232,7 @@ .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL,