Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O

[Lu, Yinghai]

Where will be ram_enabled? Cache or Ram?

YH

-----Original Message-----
From: [e-mail]
[mailto:[e-mail]] On Behalf Of Carl-Daniel
Hailfinger
Sent: Wednesday, February 28, 2007 10:12 AM
To: Lu, Yinghai
Cc: Stefan Reinauer; [e-mail]
Subject: Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O

On 28.02.2007 18:22, Lu, Yinghai wrote:
> In the V2 you need to everyone happy
> ROMCC: print
> CAR: a. print
>   b. printk
>   c. print when ram is enabled already 
>   d. printk when ram is enabled already
>
> c/d are introduced for USBDebug direct, because dbg_info will be in

RAM
> instead of cache..

Can we use a variable to automatically call the right version in CAR?
I know the code below will not work, but to give you an idea...

int do_printk(int msg_level, const char *fmt, ...)
{
    if (ram_enabled)
    	return do_ram_printk()
    else
    	return do_car_printk()
}

Or we do that with function pointer manipulation.

Comments?

Regards,
Carl-Daniel