Re: [coreboot] [PATCH] remove annoying noisy message

[Myles Watson]

> I'm mixed on this one, but at the same time, I bet there are few
> broken devices that return 0 as there were in the old days.

In that case the check could be split, so that the message is only printed
in the cases where it isn't 0xffffffff.  Then only the broken boards would
print the message.

dummy.path.pci.devfn = devfn;
    	id = pci_read_config32(&dummy, PCI_VENDOR_ID);
    	/* Have we found something?
    	 * Some broken boards return 0 if a slot is empty, but
    	 * the expected answer is 0xffffffff
    	 */
    	if (id == 0xffffffff) {
    		return NULL;
    	}
    	if ((id == 0x00000000) || (id == 0x0000ffff) ||
    	    (id == 0xffff0000)) {
    		printk(BIOS_SPEW, "%s, bad id 0x%x\n",
dev_path(&dummy), id);
    		return NULL;
    	}
    	dev = alloc_dev(bus, &dummy.path);

Thanks,
Myles