v2 uses the #if X == 1
v3 uses #ifdef X
I doubt we want condifional compilation at all. coreboot is firmware, not an OS, and we don't want lots of variant versions. I lean toward yanking this type of conditional compilation.
I think the reason this was originally done was for size. There might be some people who are unhappy with HT, PCIe, and PCIx support compiled in for their embedded box.
That being said, if the size isn't an issue, I'm all for yanking the ifs.
Myles