Re: [coreboot] [PATCH] Add QWord support to acpigen

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Carl-Daniel Hailfinger wrote:
> Add QWord support to acpigen.
>
> Add TOM2 to the K8 DSDT.
>
> Signed-off-by: Carl-Daniel Hailfinger
>
> Compile tested only.

Hi, thanks for doing this. However there are two issues.

1) the opcode is 0xe and not 0xd
2) the << 32 must be cast to unit64_t first.

I'm attaching patch here. It works otherwise!

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmZ8k8ACgkQ3J9wPJqZRNUbtQCguWFybWRu5NoGZtXY02mpPghE
SqwAnAkGb1IVX6STwU3z/TNr2CaMG7Of
=azgs
-----END PGP SIGNATURE-----