Re: [LinuxBIOS] [PATCH] LAR checksums

[Alex Beregszaszi]

Hi,

On Thu, 2007-09-06 at 03:23 +0200, Alex Beregszaszi wrote:
> Hi,
>
> checksum-fix.diff fixes a checksum calculation bug in the lar utility,
> where it would checksum less bytes then desired.
>
> lar-check-sum.diff implements checksum checking in the runtime lar code.
>
> I implemented the check inside the filename check, thus it wont be
> executed on unneeded entries. As my assumption was that I cant modify
> the memory, the code is skipping bytes between 20-24 of the header
> (checksum field) to generate a correct sum.
>
> This is bad, as the numbers shall be updated at every lar structure
> change. This is good, as we are not writing to memory.

Any comments to this?