On Tue, Nov 13, 2007 at 01:43:30PM +0100, Peter Stuge wrote:
On Tue, Nov 13, 2007 at 12:22:44PM +0100, Uwe Hermann wrote:
Various small fixes to make the Tyan S1846 match the format of the other boards in this patch series.
No reason to hold this up. One comment below, but otherwise:
Acked-by: Peter Stuge peter@stuge.se
Thanks, r2960.
- device pci_domain 0 on
- device apic_cluster 0 on # APIC cluster
- chip cpu/intel/slot_2 # CPU (FIXME: It's slot 1, actually)
device apic 0 on end # APIC- end
- end
Please explain this slot_1 vs slot_2 a little more in detail in the comment.
The comments should really be removed soon (they're in every 440BX board code btw). The actual boards have a Slot 1 socket, but we don't yet have a cpu/intel/slot_1 directory we could use in Config.lb.
There's a slot_2 directory though, and as it's very similar to slot_1 (probably even _identical_ for our purposes, but I didn't check), we're using slot_2 for now.
Uwe.