* Eric W. Biederman ebiederman@lnxi.com [051026 19:35]:
Bad idea?
Nope. I don't think so.
Richard's objection that a checkin will take a couple of minutes more is true though. This might become annoying.
Sounds like we really might want a development tree and a stable tree and have a 2 step process for merging into stable. But then again I see it coming that noone will really use the stable tree as it is the least common denominator
I think abuild.sh will need some improvements so it can build all of the boards, and this won't replace code reviews.
Or fixing the build process might help. Image sizes are really sensitive and get adjusted from time to time. This looks wrong to me. The image size is something that I might want to decide when everything built correctly and I compose the final image. Then abuild might check and tell "minimum image size: 512k" or whatever but not just fail.
As for the code reviews you are completely right. Code quality is nothing that can be ensured by a bunch of automated tools. But it can't be guaranteed by code reviews either, since even by careful looking I can't guess if a certain piece of code will actually compile unless it is reaaally nasty stuff.
We all agree that the LNXI merge is a good thing, but it is causing us a little headache now and then. Nothing to worry, nor to argue about - but still something that needs a little fixup.
Do you have a time frame for getting things into shape, or shall anyone else try to fix up their own builds? (I'd prefer the first ;))
Stefan