On 4 Apr 2013 at 23:16, Paul Menzel wrote:
thank you for the patch!
gerne :-)
The coreboot project, and superiotool therefore too, uses Gerrit for patch reviews [1]. Could you please upload/push the patch there? Thanks, Paul [1] http://www.coreboot.org/Git
I've scratched my head for a bit, found out that a Google account will do for auth, then gave it a try, took the plunge into Gerrit / SSH keys / basic GIT... and voila, I have my first commit at review.coreboot.org: http://review.coreboot.org/#/c/3027/ If there's no significant lint, then I'm a living proof that a trained monkey with zero GIT experience can do it, based on coreboot's tutorials... ;-)
BTW, there are two small corrections, in the GIT patch compared to my original e-mailed patch. Just in case someone someday finds this e-mail thread first, the corrected flat patch is attached here again...
Thanks for your help :-)
Frank Rysanek
P.S.: makes me wonder if I should try to refactor and resubmit my earlier patch to superiotool, which aimed to make it reliably detect multiple SuperIO chips and provide framework for further extensions (write support for instance) http://patchwork.coreboot.org/patch/2581/
The following section of this message contains a file attachment prepared for transmission using the Internet MIME message format. If you are using Pegasus Mail, or any other MIME-compliant system, you should be able to save it or view it from within your mailer. If you cannot, please ask your system administrator for assistance.
---- File information ----------- File: W83627UHG_rev-E.patch Date: 5 Apr 2013, 9:52 Size: 2847 bytes. Type: Unknown