-----Original Message----- From: Marc Jones [mailto:marc.jones@amd.com] Sent: Thursday, October 23, 2008 5:05 PM To: Myles Watson Cc: ron minnich; Carl-Daniel Hailfinger; Coreboot Subject: Re: [coreboot] HT devices in v3
Myles Watson wrote:
On Thu, Oct 23, 2008 at 4:03 PM, Myles Watson <mylesgw@gmail.com mailto:mylesgw@gmail.com> wrote:
> > hold off on device tree for a bit. Marc is guiding me in a cleanup > effort and we have a pending patch. Just keep going on via :-) > I wonder how we could best collaborate here. I'm in the middle of messing with a lot of files. I guess if you can just fix it... Thanks, Myles
I have to go right now, but here's part of my patch. It adds the 8132 to the build, and changes the dts.
Hopefully it either saves you time or confirms what you're doing.
Signed-off-by: Myles Watson <mylesgw@gmail.com mailto:mylesgw@gmail.com>
Myles,
The kconfig and dts changes seem to be improved, good work. The area Ron and I are working on is phases and device operation function pointers. I am not sure about the changes in the 8111.c since it will get called like it used to in the code ron has.
I'm glad. That doesn't sound like it will overlap too much. The 8111 changes were all cosmetic. I was in a hurry so I didn't include a very good change log. The only non white space change was to change lpc_dev to slot_dev because it could be an lpc or a pci device.
Thanks, Myles
Marc
-- Marc Jones Senior Firmware Engineer (970) 226-9684 Office mailto:Marc.Jones@amd.com http://www.amd.com/embeddedprocessors