Re: [LinuxBIOS] [PATCH] remove duplicated microcode updates for some Intel processors

[ron minnich]

On Dec 29, 2007 9:00 PM,   wrote:
> Quoting Corey Osgood :
> > Acked-by: Corey Osgood
> >
> > how long has it been since we've updated the microcode updates?
>
> No idea, but remember the email below from 12/12/07? Looks like an
> update is in order, but I wouldn't know where to start.
>
> Thanks - Joe
> > Quoting [e-mail]:
> > > Hello,
> > >
> > > Yesterday I wrote some code for the Syslinux boot loader that is meant
> > > to boot different images based on which revision of the CPU microcode
> > > that is currently loaded in the CPU (yes, this is a bit strange but we
> > > have a very good reason for it). I then compared my implementation with
> > > a few others an ran across yours, in
> > > http://www.openbios.org/viewvc/trunk/LinuxBIOSv2/src/cpu/intel/microcode
> > > /microcode.c?view=markup
> > >
> > > Question to you guys: why is the first wrmsr instruction there? From my
> > > understanding, by not properly initialising ECX, EAX and EDX this will
> > > overwrite whatever is in the MSR pointed to by ECX?!
> > >
> > > BTW I tried out your code on our target hardware (Intel Celeron M, 600
> > > MHz) and with that first wrmsr line in place it hangs and without it, it
> > > runs just fine.
> > >
> > > Just wanted to let you know.
> > >
> > > Best regards,
> > > Martin Karlsson

I submitted the patch to remove this extraneous wrmsr a while back. I
can't recall if it was acked and committed, but I thought it was.

I have two other patches in limbo:
1. fix to buildtarget to enable switches like -fno-stack-protector
2. fix to lib/lar.c to enable parameter passing to lar executables.

thanks

ron