Re: [coreboot] [PATCH] flashrom: Add support for 8 new chips, fix up 2 existing chips

[Peter Stuge]

Carl-Daniel Hailfinger wrote:
> +#define MX_29F002B		0x34
> +#define MX_29F002T		0xB0

Yeah. Please don't do this. Put them in the struct.
> {"Winbond",	"W39V040C",		0xda,		0x50,			512,	64*1024,	TEST_OK_PREW,	probe_w39v040c,		erase_w39v040c,			write_w39v040c},
> {"Winbond",	"W39V040C",		WINBOND_ID,	0x50,			512,	64*1024,	TEST_OK_PREW,	probe_w39v040c,		erase_w39v040c,			write_w39v040c},

..

//Peter