Re: [coreboot] [PATCH] add basic support for mainboard iBASE:MB899

[Stefan Reinauer]

On 4/20/10 5:57 PM, Peter Stuge wrote:
> Bernhard Wiedemann wrote:
> > This patch adds basic support for mainboard iBASE:MB899
> >
> > based on Kontron 986LCD-M
>
> Great to support new boards! :)
>
> In the course of this work did you notice any natural parts which
> could or should be factored out, to avoid duplicated code in the two
> ports?
>
> There is a fair amount of ACPI source, romstage code and mainboard
> code in your patch. How much of it is similar or identical to the
> Kontron port?

A lot of the code is copied from the kontron board but should not be,
like control over the three gbit ethernet interfaces of the kontron,
which the ibase does not have