Re: [coreboot] [PATCH] i810 GFXUMA and Northbridge fixes

[Stefan Reinauer]

On 6/20/10 7:59 AM, Joseph Smith wrote:
> if (CONFIG_VIDEO_MB == 512) {
> igd_memory = (CONFIG_VIDEO_MB);
> printk(BIOS_DEBUG, "%dKB IGD UMA\n", igd_memory >> 10);
> } else {
> igd_memory = (CONFIG_VIDEO_MB * 1024);
> printk(BIOS_DEBUG, "%dMB IGD UMA\n", igd_memory >> 10);
> }

You might want to read the SMRAM register intead of relying on the
setting of the config variable in case an invalid value sneaked in.

Other than that:

Acked-by: Stefan Reinauer