Re: [coreboot] flashrom: Add board enable for VIA EPIA SP.

[Uwe Hermann]

On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> dev = pci_dev_find(0x1106, 0x3227);	/* VT8237 ISA bridge */

Is this really meant to be VT8237 or should it be VT8237R?
> if (!dev) {
> fprintf(stderr, "\nERROR: VT8237 ISA bridge not found.\n");

Ditto.
> return -1;
> }
> /* All memory cycles, not just ROM ones, go to LPC */
> val = pci_read_byte(dev, 0x59);
> val &= ~0x80;

Just some cosmetics: I personally find the

val &= ~(1 << 7);

notation clearer for manipulating bits.

Otherwise this looks good. With the above changes:

Acked-by: Uwe Hermann

If nobody complains I'll commit with the changes above.

Uwe.