flashrom: Add board enable for VIA EPIA SP.

[Luc Verhaegen]

Luc Verhaegen.
SUSE/Novell X Driver Developer.

[Peter Stuge]

On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> Flashrom: Add board enable for VIA EPIA SP.
>
> Signed-off-by: Luc Verhaegen

If it works: (I can't test)

Acked-by: Peter Stuge
> Index: board_enable.c
>
> --- board_enable.c	(revision 3089)
> +++ board_enable.c	(working copy)
> @@ -3,7 +3,7 @@
> Copyright (C) 2005-2007 coresystems GmbH
> Copyright (C) 2006 Uwe Hermann
> Copyright (C) 2007 Luc Verhaegen
> Copyright (C) 2007-2008 Luc Verhaegen
> Copyright (C) 2007 Carl-Daniel Hailfinger
> This program is free software; you can redistribute it and/or modify
>
> @@ -213,6 +213,28 @@
>  }
>
> /**
> Suited for VIAs EPIA SP.
> */
>
> +static int board_via_epia_sp(const char *name)
> +{
> struct pci_dev *dev;
> uint8_t val;
> dev = pci_dev_find(0x1106, 0x3227);	/* VT8237 ISA bridge */
> if (!dev) {
> fprintf(stderr, "\nERROR: VT8237 ISA bridge not found.\n");
> return -1;
> }
> /* All memory cycles, not just ROM ones, go to LPC */
> val = pci_read_byte(dev, 0x59);
> val &= ~0x80;
> pci_write_byte(dev, 0x59, val);
> return 0;
>
> +}
>
> +/**
> Suited for ASUS P5A.
> This is rather nasty code, but there's no way to do this cleanly.
>
> @@ -393,6 +415,8 @@
>     NULL, NULL, "VIA EPIA M/MII/...", board_via_epia_m},
>    {0x1106, 0x3177, 0x1043, 0x80A1, 0x1106, 0x3205, 0x1043, 0x8118,
>     NULL, NULL, "ASUS A7V8-MX SE", board_asus_a7v8x_mx},
> {0x1106, 0x3227, 0x1106, 0xAA01, 0x1106, 0x0259, 0x1106, 0xAA01,
> NULL, NULL, "VIA EPIA SP", board_via_epia_sp},
> {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498,
>   NULL, NULL, "Tyan Tomcat K7M", board_asus_a7v8x_mx},
>  {0x10B9, 0x1541, 0x0000, 0x0000, 0x10B9, 0x1533, 0x0000, 0x0000,
>

[Luc Verhaegen]

On Wed, Feb 06, 2008 at 06:45:39PM +0100, Peter Stuge wrote:
> On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> > Flashrom: Add board enable for VIA EPIA SP.
> >
> > Signed-off-by: Luc Verhaegen
>
> If it works: (I can't test)
>
> Acked-by: Peter Stuge

Yeah, it does, i needed the SP to flash a similar FWH rom for another 
machine. That other machine now works, after stumbling over the "remove 
jumper first, you idiot" bit, so it has been tested fruitfully :)

Luc Verhaegen.
SUSE/Novell Driver Developer.

[Uwe Hermann]

On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> dev = pci_dev_find(0x1106, 0x3227);	/* VT8237 ISA bridge */

Is this really meant to be VT8237 or should it be VT8237R?
> if (!dev) {
> fprintf(stderr, "\nERROR: VT8237 ISA bridge not found.\n");

Ditto.
> return -1;
> }
> /* All memory cycles, not just ROM ones, go to LPC */
> val = pci_read_byte(dev, 0x59);
> val &= ~0x80;

Just some cosmetics: I personally find the

val &= ~(1 << 7);

notation clearer for manipulating bits.

Otherwise this looks good. With the above changes:

Acked-by: Uwe Hermann

If nobody complains I'll commit with the changes above.

Uwe.

[Luc Verhaegen]

On Wed, Feb 06, 2008 at 07:05:46PM +0100, Uwe Hermann wrote:
> On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> > dev = pci_dev_find(0x1106, 0x3227);	/* VT8237 ISA bridge */
>
> Is this really meant to be VT8237 or should it be VT8237R?

Hrm... Took the disk out already :( Chip itself is covered by a 
heatsink.

The machine i needed to flash the bios for has a VT8237A, and this has 
0x3337 for the ISA bridge.

pciids.sf.net has the SP device down for a plain VT8237, confirms 
the VT8237A and has 0x3372 for VT8237S.

I'll guess i'll just give in and install a new suse for the p4m900 and 
return the other disk to its original owner (the SP).
> > val &= ~0x80;
>
> Just some cosmetics: I personally find the
>     val &= ~(1 << 7);
>
> notation clearer for manipulating bits.

Taste :)
> If nobody complains I'll commit with the changes above.

Let me get back to you on the identification of the devices.

Luc Verhaegen.
SUSE/Novell X Driver Developer.

[Luc Verhaegen]

On Wed, Feb 06, 2008 at 07:59:48PM +0100, Luc Verhaegen wrote:
> On Wed, Feb 06, 2008 at 07:05:46PM +0100, Uwe Hermann wrote:
> > On Tue, Feb 05, 2008 at 09:47:18PM +0100, Luc Verhaegen wrote:
> > > dev = pci_dev_find(0x1106, 0x3227);	/* VT8237 ISA bridge */
> >
> > Is this really meant to be VT8237 or should it be VT8237R?
>
> Hrm... Took the disk out already :( Chip itself is covered by a 
> heatsink.
>
> The machine i needed to flash the bios for has a VT8237A, and this has 
> 0x3337 for the ISA bridge.
>
> pciids.sf.net has the SP device down for a plain VT8237, confirms 
> the VT8237A and has 0x3372 for VT8237S.
>
> I'll guess i'll just give in and install a new suse for the p4m900 and 
> return the other disk to its original owner (the SP).

Nope... lspci lists nothing VT8237Rish... Just plain VT8237.

Luc Verhaegen.
SUSE/Novell X Driver Developer.