On Fri, Oct 16, 2009 at 8:39 AM, Peter Stuge peter@stuge.se wrote:
Myles Watson wrote:
Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same values as
Can we just remove it from newconfig and Kconfig? It's never used in the code.
Or fix the code? Shouldn't it be used?
For what?
Stop scanning PCI busses?
Right now the code scans the root bus and any bus it can find from there. It just scans until it finds no more devices which have a bus. I don't think we want to change the code to blindly scan from 0->MAX_PCI_BUSES. On my Tyan s2895 Board there are 6 PCI buses as it's configured: 0,1,2,40,41,42,80. You can plug in a card that will make more somewhere, but 3-39,43-79,81-... don't need to be scanned.
Thanks, Myles