Re: [coreboot] [PATCH 4/6] Support for the Intel 945 northbridge

[Myles Watson]

> Myles Watson wrote:
> > > Support for the Intel 945 northbridge.
> >
> > Sorry I'm late.  I know it's already in, but I was in the middle of
> > reviewing it.  I prefixed my comments with //, I hope that helps you
>
> find
> > them faster.
>
> Ok, trying to address the issues:

Thanks.  It makes it more motivating to do future reviews.
> > //Consistency with \r\n ...
> > > printk_debug("ok\r\n");
> > >
> > > +}
> > >
> > > +static void i945_setup_egress_port(void)
> > > +{
> > > u32 reg32;
> > > u32 timeout;
> >
> > //and just \n
>
> Which one is the right one to use these days?

I think the consensus was just \n.  That's what v3 uses all the way through.

Thanks,
Myles