Re: [coreboot] [v2] r4188 - trunk/coreboot-v2/targets/hp/dl145_g3

[Myles Watson]

On Wed, Apr 22, 2009 at 5:32 PM, Stefan Reinauer  wrote:
> On 23.04.2009 0:47 Uhr, Myles Watson wrote:
>
> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of [e-mail]
> Sent: Wednesday, April 22, 2009 4:43 PM
> To: [e-mail]
> Subject: [coreboot] [v2] r4188 - trunk/coreboot-v2/targets/hp/dl145_g3
>
> Author: stepan
> Date: 2009-04-23 00:43:02 +0200 (Thu, 23 Apr 2009)
> New Revision: 4188
>
> Added:
>    trunk/coreboot-v2/targets/hp/dl145_g3/Config-abuild.lb
> Log:
> fix compilation of hp dl145
>
> Signed-off-by: Stefan Reinauer 
> Acked-by: Stefan Reinauer
>
> Thanks for fixing it.  I didn't think I'd need to add Config-abuild.lb for
> this board.  Tyan s2892 doesn't have one.
>
> Is there a rule?
>
> If there is none, abuild will create one with a ROM_IMAGE_SIZE of 0x17000
> (92kb).. Unfortunately abuild can not figure out how much space is needed to
> fit the image before the linker fails.

OK.  It looks like we could remove all but s2892_fam10 by increasing
that size to 0x20000 (128K.)

For some reason s2892_fam10 needs 0x34000 (208K.)

Signed-off-by: Myles Watson

This patch would be followed by lots of svn rm targets/*/Config-abuild.lb.

The only downside I see is that Patrick uses Config-abuild.lb files
instead of the Config.lb files:

On Mon, Apr 27, 2009 at 12:35 PM, Patrick Georgi  wrote:
> Am Montag 27 April 2009 20:12:45 schrieb Myles Watson:
> > I don't understand why this board needs a Config-abuild.lb.  It seems like
> > if we want one it should build normal and fallback images like Config.lb
> > does.
>
> I can't tell you why it is already there. But, as I use abuild for my local
> work, I rely on those files and edit those when necessary.

I don't like having both files if we can get away from it.  Maybe
abuild just use the Config.lb unless there's a Config-abuild.lb.
> This is one thing where further CBFS integration in v2 can bring us a big
> gain... we could drop 90% of the Config-abuild.lb files (plus the ugly image
> calculation that Carl-Daniel factored out so nicely)

That'll be great.

Thanks,
Myles