Re: [coreboot] [PATCH] flashrom: Use accessor functions for MMIO

[Carl-Daniel Hailfinger]

On 17.05.2009 17:43, Uwe Hermann wrote:
> On Sun, May 17, 2009 at 02:22:07AM +0200, Carl-Daniel Hailfinger wrote:
> > Use accessor functions for MMIO. Some MMIO accesses used volatile,
> > others didn't (and risked non-execution of side effects) and even with
> > volatile, some accesses looked dubious.
> >
> > Since the MMIO accessor functions and the onboard flash accessor
> > functions are functionally identical (but have different signatures),
> > make the flash accessors wrappers for the MMIO accessors.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Uwe Hermann
>
> I tested read, write, erase with this patch on a random board to make
> sure nothing breaks.

Thanks, committed in r524 with the whitespace fixes you requested.

Regards,
Carl-Daniel