Re: [coreboot] [v3] [patch] k8 fid/vid update

[Uwe Hermann]

On Mon, Nov 03, 2008 at 03:45:27PM -0700, Marc Jones wrote:
> Update K8 FID/VID setupto match coreboot v2. Add support for 100MHz FIDs (revG).
>
> Signed-off-by: Marc Jones

Great, thanks!

Acked-by: Uwe Hermann

Can't test much in v3 yet, but the patch looks good. Minor nitpicks
below.
> if (fid_temp > fid_max)
> if(fid_temp > fid_max) {

^
                space
> 	printk(BIOS_DEBUG, "fid_temp 0x%x > fid_max 0x%x\n",
> 		fid_temp, fid_max);
> break;
> }
> send = (apicid<<24) | (readback & 0x00ffff00); 
> send = (apicid<<24) | (readback & 0x00ffff00);

^ ^
                             space

Uwe.