Re: [coreboot] [PATCH] ASUS P2B-LS support, RAM detection for 440BX, add Slot 1 CPU, Microcode for Intel Tualatin CPUs

[Uwe Hermann]

Hi Keith,

On Tue, Mar 02, 2010 at 11:19:24PM -0500, Keith Hui wrote:
> This thing is now ready for more exposure. Scratch my previous "patch" -
> this is my first real deal.
> Adds Asus P2B-LS mainboard
> Adds RAM detection for i440bx (based on i82830 code). We're no longer hard
>
> coded for 64MB on one row!
> Adds a proper Slot 1 cpu under src/cpu/intel/slot_1. It's a stub copied
>
> from slot_2 but addresses a few FIXMEs. My P2B-LS code refers to this.
> Adds microcode for Intel Tualatin CPUs, cpuid 6B1 and 6B4.* Actually
>
> loading them is pending.
>
> Signed-off-by: Keith Hui

Great stuff, thanks a lot!

I'll review and/or test the individual pieces one by one and commit
them as I progress. (small note for the next patch: please split up
the stuff in multiple smaller, independent patches, that makes it
easier to review and test; no need to re-send this patch though).

Uwe.