Re: [coreboot] [PATCH] s289x ACPI fix

[ron minnich]

On Fri, Oct 16, 2009 at 7:55 AM, Myles Watson  wrote:
> Before it gets optimized out it will look for the definition of the function
> which wasn't compiled in and whose headers weren't included.  Won't it
> break?  I could try it with some of the k8 raminit code that has conditional
> includes all over the place.

It depends to some extent on how that code is set up.

We do conditional function definition in many .h files a la Linux style:
#if CONFIG_THIS == 0
#define x()
#endif

So it's likely that
if (CONFIG_THIS) {
         x();
}

would work.

Anyway, I'm not going to worry about this if nobody else does :-)

Just FYI, the romcc code depends on romcc's intelligent optimization.

ron