On 12.03.2008 23:43, Rudolf Marek wrote:
Hello,
Following patch extends the ROM decoding to last 1MB, allowing to use larger flashes such as SST49LF080A: 1024K x8 (8 Mbit)
Tested on my system, the flash is found and if I use coreboot in second half it works too.
Signed-off-by: Rudolf Marek r.marek@assembler.cz
Regardless of how/whether you address my comments below, this is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, Rudolf
Regards, Carl-Daniel
Index: src/southbridge/via/vt8237r/vt8237r_early_smbus.c
--- src/southbridge/via/vt8237r/vt8237r_early_smbus.c (revision 3134) +++ src/southbridge/via/vt8237r/vt8237r_early_smbus.c (working copy) @@ -212,3 +212,18 @@ else PRINT_DEBUG("Done\r\n"); }
+void enable_rom_decode(void) +{
- device_t dev;
- /* Power management controller */
- dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA,
PCI_DEVICE_ID_VIA_VT8237R_LPC), 0);- if (dev == PCI_DEV_INVALID)
die("SB not found\r\n");- /* ROM decode last 1MB FFC00000 - FFFFFFFF*/
Is it possible to decode more than the last 1MB and do we want to make this configurable?
- pci_write_config8(dev, 0x41, 0x7f);
+}
=================================================================== --- src/mainboard/asus/a8v-e_se/cache_as_ram_auto.c (revision 3134) +++ src/mainboard/asus/a8v-e_se/cache_as_ram_auto.c (working copy) @@ -192,6 +192,7 @@ w83627ehg_enable_serial(SERIAL_DEV, TTYS0_BASE); uart_init(); console_init();
enable_rom_decode();
print_info("now booting... fallback\r\n");
@@ -207,6 +208,7 @@ /* Allow the HT devices to be found. */ enumerate_ht_chain();
Is the added newline above intentional?
/* Is this a deliberate reset by the BIOS? */ if (bios_reset_detected() && last_boot_normal_x) { goto normal_image;