Re: [coreboot] [PATCH] Enable maximum decoded range for VT8237*

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> If not, we should make a test case and send it to eric.

It does not. I tried what you suggested. What now?
> ....
> > +static void bootblock_southbridge_init(void) {
>
> functions should have their opening bracket on the next line

Aha ok will fix it for a final patch.
> > /* ROM decode last 8MB FF800000 - FFFFFFFF on VT8237S/VT8237A */
> > /* ROM decode last 4MB FFC00000 - FFFFFFFF on VT8237R */
> > /* get SB on 0:11.0, because pci_locate_device construct similar in
> >   enable_rom_decode() did not worked for some reason */
> > pci_write_config8(PCI_DEV(0,0x11,0), 0x41, 0x7f);
> >
> > +}
>
> Is the device always on 0, 0x11, 0? If not, we should add a more
> explicit comment saying TODO and explaining why the broken code was
> checked in.

Yes it it should although VT8237S has programmable SB IDSEL never seen any
VT8237 on something else than 11.0, and I did not found any straps for it just
a sw reg.

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvOJt8ACgkQ3J9wPJqZRNVA4QCgpApwVfH4rnmlbsuiVkgCKbMW
ijMAn0K26Fuax7CWJJ6J0HCjcE5Ua7S8
=DzHk
-----END PGP SIGNATURE-----