Re: [LinuxBIOS] Remaining MCP55 bits (please comment!)

[Ward Vandewege]

Hi all,

What's the status on this? It would be really great to have the MCP55 code
merged into the v2 tree.

Thanks,
Ward.

On Wed, Mar 21, 2007 at 09:06:51AM -0700, Lu, Yinghai wrote:
> Please check the comment below:
>
> -----Original Message-----
> From: [e-mail]
> [mailto:[e-mail]] On Behalf Of Stefan Reinauer
> Sent: Wednesday, March 21, 2007 5:40 AM
> To: Ed Swierk
> Cc: Carl-Daniel Hailfinger; Ward Vandewege; LinuxBIOS
> Subject: Re: [LinuxBIOS] Remaining MCP55 bits (please comment!)
> Ed Swierk  [070319 20:01]:
> > Index: src/devices/hypertransport.c
> >
> > --- src/devices/hypertransport.c.orig
> > +++ src/devices/hypertransport.c
> > @@ -279,20 +279,7 @@ static void ht_collapse_early_enumeratio
> >    	}
> >    	/* Has the link failed? */
> >    	if (ctrl & (1 << 4)) {
> > 	/*
> > 	 * Either the link has failed, or we have
> > 	 * a CRC error.
> > 	 * Sometimes this can happen due to link
> > 	 * retrain, so lets knock it down and see
> > 	 * if its transient
> > 	 */
> > 	ctrl |= ((1 << 4) | (1 <<8)); // Link fail + Crc
> > 	pci_write_config16(prev.dev, prev.pos +
>
> prev.ctrl_off, ctrl);
> > 	ctrl = pci_read_config16(prev.dev, prev.pos +
>
> prev.ctrl_off);
> > 	if (ctrl & ((1 << 4) | (1 << 8))) {
> > 		printk_alert("Detected error on
>
> Hypertransport Link\n");
> > 		return;
> > 	}
> > 	return;