Re: [coreboot] DL145G3

[FENG Yu Ning]

Mondrian Nuessle wrote:
> as someone already pointed out, we need to enable flashing first on
> the board using a GPIO pin.
> I have attached a patch for flashrom that enables flashing on the HP
> DL145 G3. I tested it on the DL145 I have here.

That's great!

I think it is better to document some hardware information along so
that the code will be more meaningful. For example,

* What super IO is on that board?
  * Are those configuration IO port numbers default value or board
    specific?
  * The function of the bits we are modifying (better all bits in that
    register).

Hope that is not a silly suggestion.

yu ning