Re: [coreboot] [PATCH]Remove non-CBFS

[Myles Watson]

> Index: src/devices/pci_rom.c
>
> --- src/devices/pci_rom.c	(Revision 4696)
> +++ src/devices/pci_rom.c	(Arbeitskopie)
> @@ -35,17 +35,15 @@
>    struct rom_header *rom_header;
>    struct pci_data *rom_data;
> if (dev->on_mainboard) {
>    	/* this is here as a legacy path. We hope it goes away soon.
> Users should not have to

The legacy path is the non-CBFS path and should disappear
> -#if CONFIG_CBFS == 1
> -# if CONFIG_USE_FALLBACK_IMAGE == 1
> +#if CONFIG_USE_FALLBACK_IMAGE == 1
> str_coreboot_ram_name:	.string "fallback/coreboot_ram"
> -# else
> +#else
> str_coreboot_ram_name:	.string "normal/coreboot_ram"
> -# endif
> #endif

Since normal and failover aren't supported with CBFS, can they disappear
too?
> I consider the tree ready for this as there are no known bugs anymore
> (except the one fixed by that other patch). Speak up if you disagree (I
> intend to wait with committing this patch until saturday evening CEST)

The sooner the better.  Non-CBFS is already bit rotting.
> Signed-off-by: Patrick Georgi

Acked-by: Myles Watson

Thanks,
Myles