Re: [coreboot] r3723 - trunk/util/flashrom

[Peter Stuge]

[e-mail] wrote:
> +++ trunk/util/flashrom/chipset_enable.c	2008-11-03 00:20:22 UTC (rev 3723)

..
> case BUS_TYPE_ICH9_SPI:
> /* TODO: Add dumping function for ICH8/ICH9, or drop the 
>  * whole SPIBAR dumping from chipset_enable.c - There's 
>  * inteltool for this task already.
>  */
> tmp2 = *(uint16_t *) (spibar + 0);
> printf_debug("0x00: 0x%04x (HSFS)\n", tmp2);
> printf_debug("FLOCKDN %i, ", (tmp >> 15 & 1));
> printf_debug("FDV %i, ", (tmp >> 14) & 1);
> printf_debug("FDOPSS %i, ", (tmp >> 13) & 1);

Would have been nice if this had gone into ichspi.c.

//Peter