joe@smittys.pointclark.net wrote::
Quoting Uwe Hermann uwe@hermann-uwe.de:
On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote:
Please put generic 440 code in northbridge/, and not in mainboard/440-base/
Having two northbridge directories for the same northbridge sounds complex.
Full ack. Northbridge-specific code belongs in src/northbridge/*.
However, this is not northbridge specific code. It's more like "common code which somewhat similar mainboards share". Theoretically this could include even more (non-440BX) boards which are also similar enough, but for now I concentrated on 440BX boards.
If we later add non-440bx boards (e.g. 430TX or i810 or something) to the same framework, we might rename it to xyz-base (but I have no idea what a good name for xyz would be ;-)
Also, I'm a bit undecided if it should be src/mainboard/common/i440bx-base or src/mainboard/i440bx-base (i.e. put the "base" code parts in an extra directory or not). Opinions?
Uwe.
Why couldn't there just be a src/northbridge/intel/common/ directory?
Because there really is not much those supported chips have in common, yet. The register names are the same - their values and meaning changes.
I rather prefer 5 small, clean, linear chunks of code with a duplication of 30% each, than a single big, unreadable and unmaintainable chunk that supports all kinds of machines if you set the correct "configuration" variables.
Stefan