Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1238
-gerrit
commit d51cc7c82b9e672578c16f4a532f4a7877dbac56 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Wed Jul 18 14:38:54 2012 +0300
Intel and GFXUMA: drop redundant use of lb_add_memory_range()
Use of uma_resource() in northbridge code created a memory resource marked as reserved. Such resources are removed from system memory in write_coreboot_table().
Change-Id: I14bfd560140d8d30ec156562f23072bfae747bde Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/mainboard/asus/mew-am/mainboard.c | 2 +- src/mainboard/asus/mew-vm/mainboard.c | 2 +- src/mainboard/ecs/p6iwp-fe/mainboard.c | 2 +- src/mainboard/hp/e_vectra_p2706t/mainboard.c | 2 +- src/mainboard/intel/d810e2cb/mainboard.c | 2 +- src/mainboard/mitac/6513wu/mainboard.c | 2 +- src/mainboard/msi/ms6178/mainboard.c | 2 +- src/mainboard/nec/powermate2000/mainboard.c | 2 +- src/mainboard/rca/rm4100/mainboard.c | 2 +- src/mainboard/thomson/ip1000/mainboard.c | 2 +- src/northbridge/intel/i82810/northbridge.c | 9 --------- src/northbridge/intel/i82830/northbridge.c | 9 --------- 12 files changed, 10 insertions(+), 28 deletions(-)
diff --git a/src/mainboard/asus/mew-am/mainboard.c b/src/mainboard/asus/mew-am/mainboard.c index e5008b9..0909a76 100644 --- a/src/mainboard/asus/mew-am/mainboard.c +++ b/src/mainboard/asus/mew-am/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/asus/mew-vm/mainboard.c b/src/mainboard/asus/mew-vm/mainboard.c index 831be01..1d1177b 100644 --- a/src/mainboard/asus/mew-vm/mainboard.c +++ b/src/mainboard/asus/mew-vm/mainboard.c @@ -4,7 +4,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/ecs/p6iwp-fe/mainboard.c b/src/mainboard/ecs/p6iwp-fe/mainboard.c index aec1250..f4f3dc9 100644 --- a/src/mainboard/ecs/p6iwp-fe/mainboard.c +++ b/src/mainboard/ecs/p6iwp-fe/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/hp/e_vectra_p2706t/mainboard.c b/src/mainboard/hp/e_vectra_p2706t/mainboard.c index 74339e9..be17705 100644 --- a/src/mainboard/hp/e_vectra_p2706t/mainboard.c +++ b/src/mainboard/hp/e_vectra_p2706t/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/intel/d810e2cb/mainboard.c b/src/mainboard/intel/d810e2cb/mainboard.c index c55a680..710b51f 100644 --- a/src/mainboard/intel/d810e2cb/mainboard.c +++ b/src/mainboard/intel/d810e2cb/mainboard.c @@ -23,7 +23,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/mitac/6513wu/mainboard.c b/src/mainboard/mitac/6513wu/mainboard.c index 9e4ec8d..c6956ce 100644 --- a/src/mainboard/mitac/6513wu/mainboard.c +++ b/src/mainboard/mitac/6513wu/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/msi/ms6178/mainboard.c b/src/mainboard/msi/ms6178/mainboard.c index e4ba148..478cfc8 100644 --- a/src/mainboard/msi/ms6178/mainboard.c +++ b/src/mainboard/msi/ms6178/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/nec/powermate2000/mainboard.c b/src/mainboard/nec/powermate2000/mainboard.c index a26e8df..247c1f3 100644 --- a/src/mainboard/nec/powermate2000/mainboard.c +++ b/src/mainboard/nec/powermate2000/mainboard.c @@ -24,7 +24,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
struct chip_operations mainboard_ops = { diff --git a/src/mainboard/rca/rm4100/mainboard.c b/src/mainboard/rca/rm4100/mainboard.c index 653b22a..2ee26fe 100644 --- a/src/mainboard/rca/rm4100/mainboard.c +++ b/src/mainboard/rca/rm4100/mainboard.c @@ -25,7 +25,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
static void mainboard_init(device_t dev) diff --git a/src/mainboard/thomson/ip1000/mainboard.c b/src/mainboard/thomson/ip1000/mainboard.c index f6eee68..d0feb5d 100644 --- a/src/mainboard/thomson/ip1000/mainboard.c +++ b/src/mainboard/thomson/ip1000/mainboard.c @@ -31,7 +31,7 @@
int add_mainboard_resources(struct lb_memory *mem) { - return add_northbridge_resources(mem); + return 0; }
// setting the bit disables the led. diff --git a/src/northbridge/intel/i82810/northbridge.c b/src/northbridge/intel/i82810/northbridge.c index 5bf29ad..6e6c3a3 100644 --- a/src/northbridge/intel/i82810/northbridge.c +++ b/src/northbridge/intel/i82810/northbridge.c @@ -62,15 +62,6 @@ static const struct pci_driver i810e_northbridge_driver __pci_driver = { .device = 0x7124, };
-int add_northbridge_resources(struct lb_memory *mem) -{ - printk(BIOS_DEBUG, "Adding IGD UMA memory area\n"); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); - - return 0; -} - /* Table which returns the RAM size in MB when fed the DRP[7:4] or [3:0] value. * Note that 2 is a value which the DRP should never be programmed to. * Some size values appear twice, due to single-sided vs dual-sided banks. diff --git a/src/northbridge/intel/i82830/northbridge.c b/src/northbridge/intel/i82830/northbridge.c index 1b58bc1..2a7903d 100644 --- a/src/northbridge/intel/i82830/northbridge.c +++ b/src/northbridge/intel/i82830/northbridge.c @@ -52,15 +52,6 @@ static const struct pci_driver northbridge_driver __pci_driver = { .device = 0x3575, };
-int add_northbridge_resources(struct lb_memory *mem) -{ - printk(BIOS_DEBUG, "Adding IGD UMA memory area\n"); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); - - return 0; -} - #if CONFIG_WRITE_HIGH_TABLES #include <cbmem.h> #endif