On 10/9/18 6:59 PM, Philipp Stanner wrote:
Hey Nico,
Am Sonntag, den 07.10.2018, 22:56 +0200 schrieb Nico Huber:
At least since I'm working on the project it was always like this. And, IMHO, it is a good thing. The only decent x86 coreboot code I know was written when Intel didn't have their fingers in the pie.
Do the Intel engineers write bad code in your opinion? One would believe that those who know their platform best and get paid to work on it 8 hours a day produce nothing of bad quality… :|
They are not experts in software development. And the employees that write the software are not the ones who know the platforms best.
My impression is that they have no idea at all what they are doing and just test and fix as hell until it works somehow. I don't think that this is the developer's fault, though. Political decisions about software design which frameworks and tools to use etc. can get ugly code out of any developer. Taking FSP (or BIOS reference code gene- rally) for example, I guess the actual silicon init makes about 5 to 10% of the code. Everything else is just there to keep the developers from doing a good job.
So the result is probably that they work half an hour instead of 8 per day on the code that matters.
Nico