Myles Watson wrote:
## Setting this number very high will make pci_locate_device() take a long ## time when it can't find a device. ## -default CONFIG_MAX_PCI_BUSES = 3 The comments should disappear too. ... -define CONFIG_MAX_PCI_BUSES default 255 export always comment "Maximum number of PCI buses to search for devices" The rest of this has to go.
Duh! Thanks for finding it!
Uwe Hermann wrote:
Drop CONFIG_MAX_PCI_BUSES
It was added by rsmith in r2273 on 20060424, when pci_locate_device() in src/arch/i386/include/arch/romcc_io.h in fact scanned all busses:
- for(; dev <= PCI_DEV(255, 31, 7); dev += PCI_DEV(0,0,1)) {
- for(; dev <= PCI_DEV(CONFIG_MAX_PCI_BUSES, 31, 7); dev += PCI_DEV(0,0,1)) {
Today this looks like:
for(; dev <= PCI_DEV(255|(((1<<CONFIG_PCI_BUS_SEGN_BITS)-1)<<8), 31, 7); dev += PCI_DEV(0,0,1)) {
and CONFIG_MAX_PCI_BUSES is never used anywhere.
Signed-off-by: Peter Stuge peter@stuge.se
Looks like you were faster, but here's my patch nonetheless. It removeѕ some additional useless comments. Also, the change in src/config/Options.lb is not correct and will likely break the build.
Good stuff! Thanks for finding what I missed. Feel free to grab some parts from my commit message and go for it!
Drop unused and useless CONFIG_MAX_PCI_BUSES.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Acked-by: Peter Stuge peter@stuge.se