On Sat, Sep 25, 2010 at 11:15 AM, Stefan Reinauer stefan.reinauer@coresystems.de wrote:
On 9/25/10 5:19 PM, Patrick Georgi wrote:
Am 25.09.2010 16:40, schrieb repository service:
Change Log: Make globals in romstage break the build, so we don't have to wonder why variables in .data or .bss (both somewhere in ROM space) are wrong.
Instant proof that this test is useful :-)
I was wondering if that would happen. :-) Very nice!
Digging through these boards, the culprit is static u8 swaplist[] = { 0xFF, CONFIG_HT_CHAIN_UNITID_BASE, CONFIG_HT_CHAIN_END_UNITID_BASE, 0xFF }; in src/northbridge/amd/amdht/ht_wrapper.c's static BOOL AMD_CB_ManualBUIDSwapList (u8 node, u8 link, u8 **List).
This is put in .data, as it might be modified by some other user of the pointer. As far as I can see, it isn't, so that choice is harmless.
I made it const, as well as its users, and the tree compiles, but feedback on the approach of the patch and/or testing is _very_ welcome.
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Acked-by: Stefan Reinauer stepan@coresystems.de
That should be fine and shouldn't break anything. It is a buildtime setting. Marc