Re: [coreboot] [v3] r1129 makes bootblock too big

[Myles Watson]

On Thu, Feb 12, 2009 at 3:16 PM, Ronald Hoogenboom  wrote:
> On Thu, 2009-02-12 at 14:44 -0700, Myles Watson wrote:
> > On Thu, Feb 12, 2009 at 2:29 PM, ron minnich  wrote:
> > > On Thu, Feb 12, 2009 at 1:28 PM, Myles Watson  wrote:
> > > > On Thu, Feb 12, 2009 at 2:19 PM, Ronald Hoogenboom  wrote:
> > > > > Hi,
> > > > >
> > > > > After updating to r1129, adds call to allow_all_aps_stop to initram.c,
> > > > > bootblock is too big (16 bytes) and build fails. (gigabyte m57sli)
> > > >
> > > > Did we ever decide on how big was too big for the bootblock?  I
> > > > thought it was clear that we needed it to be larger for k8.  Should we
> > > > make it a parameter?  I realize it's hardcoded in lar right now.
> > >
> > > it's really hardcoded in a few places.
> >
> > So he should just take out a few printk statements to make it fit again?
> >
> > Thanks,
> > Myles
>
> Sorry, its not the addition to initram.c, but the extra stuff in
> arch/x86/amd/stage0.S that makes it too big. No printk in there...

You're right :)  I spoke too quickly.

Thanks,
Myles